fix: update tail when inserting at the end of LinkedList#2106
Open
yorunohoshi wants to merge 1 commit intotrekhleb:masterfrom
Open
fix: update tail when inserting at the end of LinkedList#2106yorunohoshi wants to merge 1 commit intotrekhleb:masterfrom
yorunohoshi wants to merge 1 commit intotrekhleb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
LinkedList.insert()method, thetailpointer was not being updated when a new node was inserted at the very end of the list (atindex = length). This caused an inconsistency wheretailremained pointed to the second-to-last node.Impact
If
append()is called immediately after such aninsert(), the newly appended node would overwrite the node previously inserted byinsert(), leading to data loss.Changes
insert()to check if the new node is inserted at thetailposition and updatethis.tailaccordingly.tailupdates even when inserting into an empty list or out of bounds.LinkedList.test.jsto verifytailconsistency and prevent regression.Checklist
npm run lintpassed).npm testpassed).