[6.x] Fixes an issue with PHP tag and assignments#13939
Open
JohnathonKoster wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Fixes an issue with PHP tag and assignments#13939JohnathonKoster wants to merge 1 commit intostatamic:6.xfrom
JohnathonKoster wants to merge 1 commit intostatamic:6.xfrom
Conversation
JohnathonKoster
changed the title
JohnathonKoster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue caused by an interaction with
{{? ?}}tags and runtime assignments.The Problem
Depending on the current setup and stack, when you use
{{? /* .... */ ?}}, the runtime would attempt to propagate changes to variable assignments from the inner scope. The runtime was missing a guard preventing assignments from being updated when they shouldn't.When assignments are updated incorrectly, you can get into a situation where outer scope variables are overwritten.
The Solution
The fix was to add an extra guard preventing the reassignment of unchanged variables, which could change their internal references as scope frames are popped.