Fix notifier Ping called with cancelled context#1149
Merged
brandur merged 1 commit intoriverqueue:masterfrom Feb 15, 2026
Merged
Fix notifier Ping called with cancelled context#1149brandur merged 1 commit intoriverqueue:masterfrom
brandur merged 1 commit intoriverqueue:masterfrom
Conversation
In waitOnce, the inner context is cancelled by drainErrChan to interrupt WaitForNotification, but the subsequent Ping call was using that same cancelled context, meaning it would always fail with context.Canceled. Save a reference to the parent (still-live) context before creating the inner cancellable context, and use it for the Ping call. Also adds a testPingInterval field to avoid the 5s wait in tests, and extends ListenerMock with a pingFunc for testing Ping behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GiGurra
force-pushed
the
fix/notifier-ping-cancelled-ctx
branch
from
6fef647 to
3121667
Compare
brandur
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitOnce, the inner context is cancelled bydrainErrChanto interruptWaitForNotification, but the subsequentPingcall was using that same cancelled context, meaning it would always fail withcontext.Canceled.Pingcall.ListenerMockwith apingFuncto enable testing Ping behavior, and adds atestPingIntervalfield to avoid the 5s wait in tests.Test plan
TestNotifier/PingUsesNonCancelledContextverifies Ping receives a non-cancelled context🤖 Generated with Claude Code