Conversation
`Test_Client_InsertNotificationsAreDeduplicatedAndDebounced` was flaky
because it depended on wall-clock timing near the 1s `FetchCooldown`
boundary. In slower CI runs, repeated `queue1` inserts could cross that
boundary and legitimately emit a second `river_insert` notification.
```
client_test.go:6737: received insert notification when it should have been debounced {topic:river_insert payload:{Queue:queue1}}
```
Drive limiter time with `client.baseService.Time.StubNowUTC(...)`
instead of sleeping on real time. Keep repeated `queue1` inserts inside
the cooldown window, then advance just past cooldown and assert `queue1`
notifies again. This matches how `maybeNotifyInsertForQueues` calls
`insertNotifyLimiter.ShouldTrigger` and keeps queue-level debounce
behavior deterministic while still verifying that `queue2` and `queue3`
are unaffected.
brandur
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test_Client_InsertNotificationsAreDeduplicatedAndDebouncedwas flaky because it depended on wall-clock timing near the 1sFetchCooldownboundary. In slower CI runs, repeatedqueue1inserts could cross that boundary and legitimately emit a secondriver_insertnotification.To fix this, drive limiter time with
client.baseService.Time.StubNowUTC(...)instead of sleeping on real time. Keep repeatedqueue1inserts inside the cooldown window, then advance just past cooldown and assertqueue1notifies again. This matches howmaybeNotifyInsertForQueuescallsinsertNotifyLimiter.ShouldTriggerand keeps queue-level debounce behavior deterministic while still verifying thatqueue2andqueue3are unaffected.