[Android] Fix variantPath for multiflavored paths

[Reeywhaar]

Summary

When working with multiflavored apps, run-android fails to install app because of incorrect directory. Given we have clientStagingDebug variant, current path is android/app/build/outputs/apk/client/staging/debug when in fact it should be android/app/build/outputs/apk/clientStaging/debug

Test Plan

Try to run-android with some multiflavored app:

android/app/build.gradle should have something like

flavorDimensions "account", "environment"
productFlavors {
    client {
        dimension "account"
        applicationIdSuffix '.client'
        versionCode android.defaultConfig.versionCode
    }
    host {
        dimension "account"
        applicationIdSuffix '.host'
        versionCode android.defaultConfig.versionCode
    }

    production {
        dimension "environment"
        versionCode android.defaultConfig.versionCode
    }
    staging {
        dimension "environment"
        applicationIdSuffix '.staging'
        versionCode android.defaultConfig.versionCode
    }
}

Checklist

• [+] Documentation is up to date.
• [+] Follows commit message convention described in CONTRIBUTING.md.
• [+] For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

[cortinico]

Don't we have tests for this?

[cortinico]

This should also be updated

[Reeywhaar]

variantAppName? Seems to be fine

[cortinico]

Oh. Does it get generated as -client-staging-debug?

[Reeywhaar]

client-staging-debug to be precise. First dash prepended here. And that is correct, that is what gradle produces

[Reeywhaar]

Fixed type error, my bad.

[thymikee]

@Reeywhaar linter is failing, can you please take a look?

[Reeywhaar]

Fixed, sorry once again!