Distinguish not found vs skipped modules#20812
Open
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Open
Distinguish not found vs skipped modules#20812ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20800
We need to distinguish not found modules from skipped modules, because these have a different effect in the caller (unless we are using
--ignore-missing-imports).I didn't really think about the daemon, I simply fall back to the old semantics (everything is not found) so there should be no change for the daemon, I added a TODO.
Implementation is straightforward: I record the suppression reason as part of the suppression hash. I also fix a stupid bug I added earlier when I mutate a list I am iterating over.