Conversation
88ffc3e to
eab99c9
Compare
blakeembrey
left a comment
There was a problem hiding this comment.
This seems hard to maintain and not a direct port of the travis code. What's the logic behind changing mocha/nyc/instanbul in this PR? Why is the README changing to badge gen?
It feels like it'd be simpler to run just the steps that you seem to trying to hack around on the versions supported. For example, no need for coverage on node 0.8.
Also, does the existing node action for installing versions not work here?
Can we avoid doing this without changing the package.json file in the test process?
|
Hi @blakeembrey This isn't a direct port because the priority was maintaining consistency with all other GH actions in the express, pillarjs, and jshttp organizations. The change in Mocha was made to use a more modern version compatible with the latest Node.js. Additionally, replacing Istanbul with NYC aligns with how coverage is tracked in all other repositories. The pipeline removes ESLint for Node.js versions 10 and below, which is consistent with previous actions. I can add it to the install step if you prefer. |
|
May be worth mentioning that the travis build is not working at the moment |
eab99c9 to
7c81ce3
Compare
7c81ce3 to
aa0d24b
Compare
|
I've refactored the CI pipeline task, and I believe it's now more closely aligned with what Travis CI pipeline did. The key differences from the Travis CI pipeline are:
@blakeembrey can you please take a look and let me know if there’s anything you think I should change? |
UlisesGascon
left a comment
There was a problem hiding this comment.
Can we add support to Node@24 and merge it? :)
Agreed to migrate to GH actions in expressjs/discussions#229
The new ci action and README.md changes are based on the respective files in accepts repository