ClassNameCheck: Retrieve extensions just once#4926
Open
staabm wants to merge 4 commits intophpstan:2.1.xfrom
Open
ClassNameCheck: Retrieve extensions just once#4926staabm wants to merge 4 commits intophpstan:2.1.xfrom
staabm wants to merge 4 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Feb 14, 2026
src/Rules/ClassNameCheck.php
Outdated
| private Container $container, | ||
| ) | ||
| { | ||
| $this->extensions = $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG); |
Member
There was a problem hiding this comment.
I don't want to do stuff in constructor, you're risking circular references. It has to be done lazily with ??= and nullable property.
Contributor
Author
There was a problem hiding this comment.
ahh right. we had this discussion already. I forgot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.