Skip to content

🌱 Add /list-e2e-steps Claude Code command#2508

Open
pedjak wants to merge 1 commit intooperator-framework:mainfrom
pedjak:list-e2e-steps
Open

🌱 Add /list-e2e-steps Claude Code command#2508
pedjak wants to merge 1 commit intooperator-framework:mainfrom
pedjak:list-e2e-steps

Conversation

@pedjak
Copy link
Contributor

@pedjak pedjak commented Feb 13, 2026

Description

Add a Claude Code skill that generates a categorized reference of all Godog e2e step definitions. Add doc comments to exported step handler functions documenting their behavior and polling characteristics.

Update e2e README with usage instructions.

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Copilot AI review requested due to automatic review settings February 13, 2026 15:34
@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f30883c
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/698f4cc5638c1e00080d1bed
😎 Deploy Preview https://deploy-preview-2508--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pedjak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pedjak pedjak changed the title Add list-e2e-steps Claude Code command 🌱 Add /list-e2e-steps Claude Code command Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds tooling and documentation to improve the discoverability and usability of Godog e2e step definitions. It introduces a Claude Code command that generates a categorized reference of all step handlers, adds comprehensive doc comments to exported step handler functions, and updates the e2e README with usage instructions.

Changes:

  • Added .claude/commands/list-e2e-steps.md with instructions for generating a categorized reference of all Godog step definitions
  • Added doc comments to ~30 exported step handler functions describing their behavior and polling characteristics
  • Updated test/e2e/README.md with instructions on using the new /list-e2e-steps Claude Code command

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.claude/commands/list-e2e-steps.md New Claude Code skill defining instructions for generating a comprehensive categorized reference of all e2e step definitions with parameters, DocString expectations, and polling behavior
test/e2e/steps/steps.go Added doc comments to exported step handler functions documenting their behavior, parameters, and whether they poll with timeout
test/e2e/README.md Added section referencing the new /list-e2e-steps Claude Code command for discovering available step definitions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 70 to 73
7. **Generic Resource Operations** - Get, delete, restore, match arbitrary resources
8. **Test Operator Control** - Marking test-operator deployment ready/not-ready
9. **Metrics** - Fetching and validating Prometheus metrics
10. **CRD Patching** - Setting minimum values on CRD fields
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category numbering skips from category 5 to category 7. Category 6 is missing. The list should be renumbered sequentially: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10.

Suggested change
7. **Generic Resource Operations** - Get, delete, restore, match arbitrary resources
8. **Test Operator Control** - Marking test-operator deployment ready/not-ready
9. **Metrics** - Fetching and validating Prometheus metrics
10. **CRD Patching** - Setting minimum values on CRD fields
6. **Generic Resource Operations** - Get, delete, restore, match arbitrary resources
7. **Test Operator Control** - Marking test-operator deployment ready/not-ready
8. **Metrics** - Fetching and validating Prometheus metrics
9. **CRD Patching** - Setting minimum values on CRD fields

Copilot uses AI. Check for mistakes.
}

// ResourceIsApplied applies the provided YAML resource to the cluster and in case of ClusterExtension it captures its name in the test context
// so it could be referred in later steps with ${NAME}
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "so it could be referred" should be "so it can be referred" or "so that it can be referred to".

Suggested change
// so it could be referred in later steps with ${NAME}
// so that it can be referred to in later steps with ${NAME}

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.25%. Comparing base (e17412a) to head (f30883c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   69.84%   73.25%   +3.41%     
==========================================
  Files         102      102              
  Lines        8496     8504       +8     
==========================================
+ Hits         5934     6230     +296     
+ Misses       2090     1799     -291     
- Partials      472      475       +3     
Flag Coverage Δ
e2e 45.92% <ø> (-0.25%) ⬇️
experimental-e2e 53.49% <ø> (+40.54%) ⬆️
unit 57.89% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add a Claude Code skill that generates a categorized reference of all
Godog e2e step definitions. Add doc comments to exported step handler
functions documenting their behavior and polling characteristics.
Update e2e README with usage instructions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant