fix: ensure test layer is in the build DAG#73
Open
LucasRoesler wants to merge 1 commit intoopenfaas:masterfrom
Open
fix: ensure test layer is in the build DAG#73LucasRoesler wants to merge 1 commit intoopenfaas:masterfrom
LucasRoesler wants to merge 1 commit intoopenfaas:masterfrom
Conversation
Some builders will exclude layers that do not contribute to the final target layer, meaning the `ship` layer for these templates. This means that the `test` layer is often optimized away by modern builders. We add the `test` layer as a dependency of the `ship` layer to ensure it is always run. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some builders will exclude layers that do not contribute to the final target layer, meaning the
shiplayer for these templates. This means that thetestlayer is often optimized away by modern builders.We add the
testlayer as a dependency of theshiplayer to ensure it is always run.Motivation and Context
design/approvedlabelResolves #71
How Has This Been Tested?
Yes, running docker build will now show the test layer in the output. This was also documented in the issue.
Types of changes
Checklist:
git commit -s