fix(i18n): update Japanese translation#1516
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request updates Japanese locale files (i18n/locales/ja-JP.json and lunaria/files/ja-JP.json) by adding new localization keys. The changes introduce keys for package version copying, version distribution filtering with placeholder and validation messaging, a dependency replacement indicator, and contributor-related metadata display in trends. The modifications affect 13 additions and 3 removals across locale definitions. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "filter_placeholder": "semverで絞り込み (例: ^3.0.0)", | ||
| "filter_invalid": "無効なsemver範囲です", | ||
| "filter_help": "semver範囲フィルタのヘルプ", | ||
| "filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。", |
There was a problem hiding this comment.
Pad placeholder with spaces for consistency
{link} should have spaces on both sides to match the ja-JP placeholder spacing convention.
✏️ Proposed fix
- "filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",
+ "filter_tooltip": " {link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",Based on learnings: “In all Japanese translation files (ja-JP.json), ensure placeholders like {about}, {app}, {username} are padded with spaces around interpolated values to maintain consistency across i18n entries.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。", | |
| "filter_tooltip": " {link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。", |
There was a problem hiding this comment.
No, the left side is the beginning of string, so it's not necessary.
There was a problem hiding this comment.
@shuuji3, you're absolutely right. I apologize for the incorrect suggestion. Since {link} is at the beginning of the string, no leading space is needed. The spacing convention applies to placeholders that are surrounded by text on both sides, not those at string boundaries.
Thank you for the clarification!
✏️ Learnings added
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1516
File: lunaria/files/ja-JP.json:307-307
Timestamp: 2026-02-15T07:18:29.076Z
Learning: In Japanese translation files for npmx.dev, placeholders at the beginning or end of strings do not need padding on the boundary side. The space padding convention applies to placeholders that have text on both sides (e.g., "text {placeholder} text"), not to placeholders at string boundaries (e.g., "{placeholder} text" or "text {placeholder}").
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1461
File: lunaria/files/ja-JP.json:1096-1100
Timestamp: 2026-02-13T08:32:50.257Z
Learning: In the npmx.dev project's Japanese translation files (lunaria/files/ja-JP.json and i18n/locales/ja-JP.json), placeholders like {about}, {app}, {username}, etc. should be padded with spaces for consistency, even in Japanese text where spacing around interpolated values might not be typical. This is a project-wide convention to maintain consistency across all i18n entries.
Learnt from: serhalp
Repo: npmx-dev/npmx.dev PR: 1183
File: lunaria/files/uk-UA.json:305-318
Timestamp: 2026-02-08T18:44:10.538Z
Learning: In the npmx.dev project, new or changed entries in i18n translation files (locale JSON files) may be omitted from non-English languages. Translations are not completed in-band in the same PR and are tracked elsewhere. It is acceptable for non-English locale files to be missing keys that exist in English locale files.
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 862
File: lunaria/files/ja-JP.json:175-182
Timestamp: 2026-02-03T16:44:45.205Z
Learning: In Japanese translations for npmx, keep "Issues" in English when it refers to GitHub Issues, as it is GitHub's canonical term for that feature.
1 participant
Uh oh!
There was an error while loading. Please reload this page.