Skip to content

feat: max width footer & navbar#8629

Open
ovflowd wants to merge 1 commit intomainfrom
feat/max-width-footer-navbar
Open

feat: max width footer & navbar#8629
ovflowd wants to merge 1 commit intomainfrom
feat/max-width-footer-navbar

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 15, 2026

This PR changes the design of NavBar and Footer so their max-width is also the same from main content, aligning the design and keeping it easier to read for extra wide screens.

image

Copilot AI review requested due to automatic review settings February 15, 2026 00:08
@ovflowd ovflowd requested a review from a team as a code owner February 15, 2026 00:08
@vercel
Copy link

vercel bot commented Feb 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 15, 2026 0:08am

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (fa01ac6) to head (7654f37).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8629      +/-   ##
==========================================
- Coverage   75.09%   75.05%   -0.05%     
==========================================
  Files         104      104              
  Lines        9088     9088              
  Branches      314      315       +1     
==========================================
- Hits         6825     6821       -4     
- Misses       2261     2265       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a consistent max-width constraint for the NavBar and Footer components by introducing an innerContainer wrapper div with max-w-10xl class in both components. This aligns these components with the main content's width constraints, improving readability on extra-wide screens.

Changes:

  • Added innerContainer wrapper to NavBar and Footer with max-w-10xl class for consistent content width
  • Refactored CSS module nesting to wrap existing styles within innerContainer selector
  • Renamed import from style to styles in NavBar for consistency

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Containers/NavBar/index.tsx Added innerContainer wrapper div and updated import name from style to styles for consistency
packages/ui-components/src/Containers/NavBar/index.module.css Restructured CSS with innerContainer class containing max-w-10xl constraint and nested all child selectors within it
packages/ui-components/src/Containers/Footer/index.tsx Added innerContainer wrapper div and refactored from explicit to implicit return
packages/ui-components/src/Containers/Footer/index.module.css Restructured CSS with innerContainer class containing max-w-10xl constraint and nested all child selectors within it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.74 MB
New Total Size 3.74 MB
Delta 477.00 B (+0.01%)

Changes

➕ Added Assets (5)
Name Size
.next/static/chunks/5ab37d6673d038fd.js 420.98 KB
.next/static/chunks/f67c6a7c53846ef0.js 136.32 KB
.next/static/chunks/a2c05f7c43768e35.js 207.34 KB
.next/static/chunks/0cb782f7535951d9.js 420.98 KB
.next/static/chunks/f2f8f6a3f710c781.js 420.98 KB
➖ Removed Assets (5)
Name Size
.next/static/chunks/ed3f66c06058478c.js 420.87 KB
.next/static/chunks/b15790ffcdf024ff.js 136.20 KB
.next/static/chunks/42bb8307ca53d9f6.js 207.34 KB
.next/static/chunks/6b7f097f221e6c7d.js 420.87 KB
.next/static/chunks/d71cee5eb2bf5bd8.js 420.87 KB

@ovflowd
Copy link
Member Author

ovflowd commented Feb 15, 2026

cc @nodejs/nodejs-website

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 93 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 94 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 96 🟢 97 🟢 100 🟢 100 🔗
/en/download 🟢 96 🟢 96 🟠 81 🟢 100 🔗
/en/download/archive/current 🟢 99 🟢 97 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 97 🟢 96 🟢 100 🔗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants