Update: Adapt tray icon to theme changes#2366
Draft
HO-COOH wants to merge 12 commits intomarticliment:mainfrom
Draft
Update: Adapt tray icon to theme changes#2366HO-COOH wants to merge 12 commits intomarticliment:mainfrom
HO-COOH wants to merge 12 commits intomarticliment:mainfrom
Conversation
4 tasks
Fix Workflow failing
…enshots Update icons and screenshots from the excel file
4 tasks
…enshots Update icons and screenshots from the excel file
…enshots Update icons and screenshots from the excel file
Open
4 tasks
Open
4 tasks
|
I like this change. Is there a similar ticket to show the new updates available indicator on the taskbar icon? |
Owner
|
what do you mean? |
Owner
|
I am afraid this is currently not possible, due to limitations with Windows AppSdk and Unpackaged apps |
|
ThemeListener to dynamically respond to theme changes, which would resolve both issues—improving visual consistency and accessibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the time of the contributors, who have to spend their free time reviewing, fixing, and testing code that does not even compile, breaks other features, or does not introduce any useful changes. Thank you for your understanding.
This PR will utilize Community ToolKit's

ThemeListenerand update the tray icon to the correct light/dark mode in time. Unlike currently it only updates when there is a package update check, causing thisBut the current
ThemeListenerdoes not work under WinUI3, and I have submitted another PR to them to get that fixed. I will mark this WIP with draft for now, and will switch the status to be ready once that PR gets merged.