fix(cli): respect dev.usePseudotranslator config to skip API validation#1984
fix(cli): respect dev.usePseudotranslator config to skip API validation#1984ShashwatpSingh wants to merge 1 commit intolingodotdev:mainfrom
Conversation
The CLI now checks both the --pseudo flag AND the dev.usePseudotranslator config when determining whether to use pseudo-localization mode. Changes: - Check ctx.config?.dev?.usePseudotranslator in provider selection - Also check config in authentication skip logic - Ensures API keys are not required when using pseudotranslator via config Fixes lingodotdev#1983
📝 WalkthroughWalkthroughModified the provider selection logic in the CLI setup to respect the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes the issue where
dev.usePseudotranslator: truein config was ignored during CLI setup, causing unnecessary API key validation.Problem
When users set:
{ "dev": { "usePseudotranslator": true } }The CLI still required API keys because it only checked the
--pseudoCLI flag, not the config option.Changes
ctx.config?.dev?.usePseudotranslatorwhen selecting the localization providerTesting
usePseudotranslator: trueworks without API keys--pseudoflag still worksFixes #1983
Summary by CodeRabbit