Add helper methods to request class#97
Conversation
|
@jeremydaly I wasn't sure the best way to add tests for these methods due to #96. Also, I wasn't sure if you'd want other helper methods. I'm going to integrate this branch into my app and test it there (so consider this a WIP). Please provide feedback on naming / other helper methods / test methodology and I can update this PR. |
Pull Request Test Coverage Report for Build 224
💛 - Coveralls |
|
Thanks for this @jthomerson. Naming conventions seem fine, but I still wavering on the I'm not sure how many of these we need, either. Like the I'm open to suggestions though. |
|
Thanks for the quick response. Yeah, I wasn't sure about the I think a separate function that returns arrays if you want it would be better than a flag because then you could actually take advantage of return types to know you're getting a string vs an array. (that thought just made me realize I forgot to update the t.js ... which leads me to this question: curious your reasoning on developing it in JS and exposing TS files vs just developing it in TS) Somewhat separately: I had a crude bunch of utilities that we'd been using for all of our APIs, and I'm investigating getting rid of them to use only your Lambda API lib. Based on this first conversion, I'm going to have a laundry list of suggestions on the API, documentation, etc. What's your preferred way of getting those? |
No description provided.