Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the integration test reliability by making tests fail fast when the binary is missing and ensuring code quality checks pass before expensive API calls. The changes focus on preventing wasted resources and providing clearer failure feedback.
- Changes binary name from test-specific to production binary name
- Converts binary missing condition from skip to fatal error for faster feedback
- Updates test prompts from "pain" to "bread" while maintaining French translation validation
- Adds
checkprerequisite to integration target to validate code quality first
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration/integration_test.go | Updates binary name, changes missing binary to fatal error, and modifies test prompts |
| Makefile | Adds check dependency to integration target to run quality checks before tests |
Comments suppressed due to low confidence (2)
integration/integration_test.go:92
- The assertion is checking for 'pain' but the test prompt was changed to ask for 'bread' in French. This should check for 'pain' (French for bread) instead.
require.Contains(t, strings.ToLower(stdout), "pain")
integration/integration_test.go:100
- The assertion is checking for 'pain' but the test prompt was changed to ask for 'bread' in French. This should check for 'pain' (French for bread) instead.
require.Contains(t, strings.ToLower(stdout), "pain")
sgoedecke
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
gh-modelsis not found for some reason, hard fail the integration tests.Also run
checkto avoid wasting tokens if some unit tests are not panning.