Remove BOOTUP_B_CGB and BOOTUP_B_AGB#74
Remove BOOTUP_B_CGB and BOOTUP_B_AGB#74dmitry-shechtman wants to merge 1 commit intogbdev:masterfrom
Conversation
|
Hmm. These have been around since v3.0, so it would count as a breaking change. And we'll still want to support them via hardware_compat.inc. If we're adding and removing bootup register constants anyway, I'd like to take time and make sure we get it right+complete. Maybe someone more experienced than me with console detection can review Pan Docs and ensure our constants are good? |
|
Also, can you please just have one "bootup register PR"? Don't worry about pushing more commits to it; after reviews/edits, if/when it's approved, we'll squash it into one commit with a sensible message (and update the hardware.inc version and history accordingly). |
|
I guess this one is 6.0 then (applies to both comments). |
|
Okay, please close your other PR and make all bootup-related changes in this one? |
|
May I ask why? The other one isn't breaking. |
|
Easier to deal with one changeset related to "bootup B registers". |
|
Superseded by #75 |
According to Pan Docs: