fix(ios): ensure empty Text has zero width and height#55555
Open
IkyssOffc wants to merge 4 commits intofacebook:mainfrom
Open
fix(ios): ensure empty Text has zero width and height#55555IkyssOffc wants to merge 4 commits intofacebook:mainfrom
IkyssOffc wants to merge 4 commits intofacebook:mainfrom
Conversation
Checks for attributedText length in RCTTextShadowViewMeasure and returns zero size immediately if empty. Fixes facebook#55468.
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This commit fixes issue facebook#17553 by adjusting the contentOffset and progressViewOffset logic. When the 'inverted' prop is active, the activity indicator now correctly remains at the visual top of the list instead of being pushed to the bottom.
This PR addresses issue facebook#17553. Currently, when 'inverted' prop is true, the RefreshControl appears at the visual bottom. This fix applies a transform style to the RefreshControl or its wrapper to ensure the activity indicator is correctly positioned at the visual top of the list for both vertical and horizontal orientations.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes issue #17553 where the RefreshControl (spinner) appears at the visual bottom on inverted lists, and issue #55468 regarding iOS Text dimensions.
Changelog:
[General] [Fixed] - Fix RefreshControl position for inverted VirtualizedList
[iOS] [Fixed] - Ensure empty Text component has zero width and height
Test Plan: