HTTP routing with Traefik: Update guide to include DHI#23769
Open
jarqvi wants to merge 16 commits intodocker:mainfrom
Open
HTTP routing with Traefik: Update guide to include DHI#23769jarqvi wants to merge 16 commits intodocker:mainfrom
jarqvi wants to merge 16 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thanks @jarqvi. Sorry, we had to quietly pause all reviews/changes for the surprise DHI free updates. Can you help update this based on that? |
Contributor
Author
|
It’s done; I made some changes in this regard. |
craig-osterhout
requested changes
Jan 6, 2026
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thanks @jarqvi.
For the linter, any content/lines in between ordered steps needs to be indented. Otherwise lgtm.
For example:
1. Run this command:
`some command`
Then xyz will happen.
2. Run this other command:
`abc`
3. ...
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
Contributor
Author
|
I’m sorry that my review of this was delayed. |
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews