test: fix pull failure assertion for Docker v29#13564
test: fix pull failure assertion for Docker v29#13564ricardobranco777 wants to merge 1 commit intodocker:mainfrom
Conversation
The error message comes now from containerd. Signed-off-by: Ricardo Branco <rbranco@suse.de>
dbe2f0f to
eadc204
Compare
There was a problem hiding this comment.
- related moby/moby#51972 (review)
Do you have more context? Is it possible that SUSE is carrying patches? While docker changed to use containerd for image store as a default, I don't think the error changed;
From docker info;
Server Version: 29.2.0
Storage Driver: overlayfs
driver-type: io.containerd.snapshotter.v1
...
containerd:
Version: v2.2.1
GitCommit: dea7da592f5d1d2b7755e3a161be07f43fad8f75
Pulling a non-existing image;
docker pull doesn_t_exists_either
Using default tag: latest
Error response from daemon: pull access denied for doesn_t_exists_either, repository does not exist or may require 'docker login'|
Our CI can run those tests with docker engine v29 without failure. |
|
Yes, there's some related discussion happening on the moby PR (moby/moby#51972) as well. At some point we may want to pass through some of those errors as-is, but we currently don't do so, so I'd like to get clear why tests are failing for @ricardobranco777 before making changes (in case there's a bug somewhere). |
What I did
Fix pull failure assertion for Docker v29.2
The error message comes now from containerd.
Related issue
#13565
Otherwise test fails with: