You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 12, 2021. It is now read-only.
Hello @orsinium
This is the minimal change to a relatively small problem which is currently completely blocking our adoption of DepHell in my development team.
I hope we can quickly merge this in, as I'd like to continue our adoption of DepHell as otherwise we're going to have to switch to a different solution as it's quite a pressing issue for us.
If there's anything that needs to be done still for you to merge this in, let me know and I'll invest the time to do so ASAP!
@orsinium
Hey, is there a reason you're not mergin in my PR?
My team's adoption of dephell is still blocked by this issue. The lack of response from your side is frustrating, you tell me to create a PR when I file an issue ticket and when I do there's no more communication. If there's a reason why you don't want to merge it in then please tell me and we can find a solution that everyone is happy with. The actual fix is less than one line of code, so it won't take a lot of time to review.
I can remove all the CI related changes in this PR if you prefer, I just implemented that to be able to get a passing run.
The actual change I need is for dephell to no longer be opinionated about whether files need extensions in order to be discoverable. If you see a problem with that, let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the following issue:
#14