feat(coder/modules/agentapi): enhance start script and configuration options and migrate to agent-helper#693
feat(coder/modules/agentapi): enhance start script and configuration options and migrate to agent-helper#693
Conversation
…options for AgentAPI server
|
wip: do not review |
…options for AgentAPI server
|
This PR has been tested with claude-code module. |
…rom agentapi module
a5f1c17 to
01873e3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dddb96b20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| module "agent-helper" { | ||
| source = "git::https://github.com/coder/registry.git//registry/coder/modules/agent-helper?ref=35C4n0r/feat-agent-helper-module" |
There was a problem hiding this comment.
Pin agent-helper source to an immutable module ref
This source points to a mutable feature branch (?ref=35C4n0r/feat-agent-helper-module) on GitHub, so module behavior is not reproducible and can break terraform init if the branch is deleted or rewritten; it also introduces a hard external fetch to GitHub for every consumer. Please use an immutable commit/tag (or a published registry module version) so existing workspaces do not fail unexpectedly.
Useful? React with 👍 / 👎.
| ARG_GOOSE_VERSION='${var.goose_version}' \ | ||
| /tmp/install.sh | ||
| EOT | ||
| agentapi_server_type = "claude" |
There was a problem hiding this comment.
Rename README input to the actual
agent_name variable
The usage example now sets agentapi_server_type, but this module does not define that input and instead requires agent_name; users copy-pasting this snippet will get an Unsupported argument error at plan/apply time and cannot configure the module successfully.
Useful? React with 👍 / 👎.
Description
Type of Change
Module Information
Path:
registry/coder/modules/agentapiNew version:
v3.0.0Breaking change: [x] Yes [ ] No
Testing & Validation
bun test)bun fmt)Related Issues
Closes: #696
Closes: #698