[main] RFC-0045: Stack management reason#3719
Open
simonjjones wants to merge 23 commits intocloudfoundry:mainfrom
Open
[main] RFC-0045: Stack management reason#3719simonjjones wants to merge 23 commits intocloudfoundry:mainfrom
simonjjones wants to merge 23 commits intocloudfoundry:mainfrom
Conversation
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- Update help description expectations to include "and current state" - Add state column to stacks listing assertions - Consolidate stack exists test contexts and add state assertions - Add state exclusion assertion to --guid test Co-authored-by: Cursor <cursoragent@cursor.com>
…erface - Display reason: whenever stack state is non-ACTIVE, even if reason is empty - Update CloudControllerClient and Actor interfaces for 3-arg UpdateStack - Regenerate fakes for updated interfaces - Fix duplicate Execute call in update-stack reason test Co-authored-by: Cursor <cursoragent@cursor.com>
- update-stack: test empty reason for non-active state, test reason with --reason flag - stack: test no reason for active state, test empty reason for non-active state, test reason for non-active state with reason Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
This PR covers additional CLI implementation details for RFC-0045: Enhance Stack Handling in Cloud Foundry. It adds an additional state reason field to output of the
cf stack&cf update-stackcommands, as well as adding the ability to modify the state reason to thecf update-stackcommand. This PR relies on changes already implemented in the Cloud Controller API and released in 1.226.0Why Is This PR Valuable?
These changes will be required for consumers to interact with the new features available in the Cloud Controller, the RFC has been accepted, indicating the changes are valuable.
Applicable Issues
N/A
How Urgent Is The Change?
This should be released promptly, so that consumers can begin to use the newly implemented CAPI features
Other Relevant Parties
Who else is affected by the change?
The Cloud Controller changes have already been released