Potential fix for code scanning alert no. 12: Workflow does not contain permissions#64
Open
simonmarty wants to merge 1 commit intomasterfrom
Open
Potential fix for code scanning alert no. 12: Workflow does not contain permissions#64simonmarty wants to merge 1 commit intomasterfrom
simonmarty wants to merge 1 commit intomasterfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Simon Marty <simon.marty@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 8 8
Lines 270 270
=======================================
Hits 265 265
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws/aws-secretsmanager-caching-python/security/code-scanning/12
To fix the problem, add a
permissionsblock to the workflow to explicitly set the minimal required permissions for theGITHUB_TOKEN. The best practice is to setcontents: readat the workflow level, which covers most use cases for CI workflows that only need to check out code and run tests. If any step requires additional permissions (such as uploading coverage reports to a pull request), those can be added as needed. In this case, since the workflow uploads coverage to Codecov (which does not require write access to the repository),contents: readis sufficient. The change should be made at the top level of the workflow file, just after thenamekey and before theonkey.Suggested fixes powered by Copilot Autofix. Review carefully before merging.