fix: enable standby mode on actors during push when usesStandbyMode is set#1016
Open
fix: enable standby mode on actors during push when usesStandbyMode is set#1016
Conversation
…rue in actor.json Previously, `apify push` only set actorStandby when creating a brand new actor. When pushing to an existing actor (the common case), usesStandbyMode from actor.json was completely ignored. This adds an actor update call after version update/create to enable standby mode on existing actors. https://claude.ai/code/session_011wdJEiBvW5AtjfL5CRNdsM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements functionality to automatically enable standby mode on existing actors when the
usesStandbyModeconfiguration is set totruein the actor.json file during a push operation.Changes
Feature Implementation: Added logic in the
pushcommand to enable standby mode on existing actors if:usesStandbyModeis configured astruein actor.jsonTest Update: Fixed the test case that was previously verifying the opposite behavior:
usesStandbyMode: trueImplementation Details
The standby mode enablement is performed after version creation but before the build process, ensuring the actor configuration is updated before building. An info message is logged to notify users when standby mode is enabled.
https://claude.ai/code/session_011wdJEiBvW5AtjfL5CRNdsM