Insert a team_name similar to team conf for 2.X compat#61923
Insert a team_name similar to team conf for 2.X compat#61923o-nikolas wants to merge 1 commit intoapache:mainfrom
Conversation
A None team name is added if we are running against an older Airflow version. Also don't use a team conf at all if the version isn't at least 3.2 (this is when airflow supports even a minimal version of multi-team)
Wait. scratch that. The issue is not with python version but Airflow version. |
This was not caught by compat tests at all. This was caught by docker-compose and k8s tests in v2-11-test branch when trying to run the e2e tests. I am not sure if there is an easy way to test it - other than building the provider and installing it with 2.11.1 |
|
Also it could be it's only 2.11.1 specific - we do not yet run 2.11.1 compatibility tests because it is not released yet. |
|
Interesting, so is the best way to test this merge this to main and then backport to the 2.11.1 branch and see if the docker-compose/k8s tests pass @potiuk? |
|
It would be very odd if this was 2.11.1 specific. It should have been caught by 2.11.0 tests on the PR? I wonder if there is a small gap in the testing matrix somewhere |
|
I think it's gap in test coverage - simply there is no e2e test in unit tests. It was discovered by celery executor getting response back from the task and I think those are mocked in the tests. Only the e2e tests that are run in 'target' airflow branch detect it. One way t do it would be to run docker and k8s tests with old image (2.11) and new providers installed. Build new image by extending the existing 2.11 one and upgrade all providers from main yes we could add it but that is a bit complex. We can add issue for it and add it some time in the future. |
A None team name is added if we are running against an older Airflow version. Also don't use a team conf at all if the version isn't at least 3.2 (this is when airflow supports even a minimal version of multi-team)
fixes #61913
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.