Skip to content

Insert a team_name similar to team conf for 2.X compat#61923

Open
o-nikolas wants to merge 1 commit intoapache:mainfrom
aws-mwaa:onikolas/celery_2_11_1
Open

Insert a team_name similar to team conf for 2.X compat#61923
o-nikolas wants to merge 1 commit intoapache:mainfrom
aws-mwaa:onikolas/celery_2_11_1

Conversation

@o-nikolas
Copy link
Contributor

A None team name is added if we are running against an older Airflow version. Also don't use a team conf at all if the version isn't at least 3.2 (this is when airflow supports even a minimal version of multi-team)

fixes #61913


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

A None team name is added if we are running against an older Airflow
version. Also don't use a team conf at all if the version isn't at least
3.2 (this is when airflow supports even a minimal version of multi-team)
@o-nikolas
Copy link
Contributor Author

@potiuk For #61913

I labelled this with full tests needed, but that didn't seem to catch the issue in the first place. Any recommendation on how to test this one for the edge case you found?

@o-nikolas o-nikolas requested a review from potiuk February 14, 2026 19:54
@eladkal
Copy link
Contributor

eladkal commented Feb 14, 2026

@potiuk For #61913

I labelled this with full tests needed, but that didn't seem to catch the issue in the first place. Any recommendation on how to test this one for the edge case you found?

I think... Full tests is running all tests (rather than selective ones) but not on all python versions.

What you want is all versions label not full tests label

Wait. scratch that. The issue is not with python version but Airflow version.

@o-nikolas o-nikolas added all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs and removed all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Feb 14, 2026
@potiuk
Copy link
Member

potiuk commented Feb 14, 2026

@potiuk For #61913

I labelled this with full tests needed, but that didn't seem to catch the issue in the first place. Any recommendation on how to test this one for the edge case you found?

This was not caught by compat tests at all. This was caught by docker-compose and k8s tests in v2-11-test branch when trying to run the e2e tests. I am not sure if there is an easy way to test it - other than building the provider and installing it with 2.11.1

@potiuk
Copy link
Member

potiuk commented Feb 14, 2026

Also it could be it's only 2.11.1 specific - we do not yet run 2.11.1 compatibility tests because it is not released yet.

@o-nikolas
Copy link
Contributor Author

Interesting, so is the best way to test this merge this to main and then backport to the 2.11.1 branch and see if the docker-compose/k8s tests pass @potiuk?

@o-nikolas
Copy link
Contributor Author

o-nikolas commented Feb 14, 2026

It would be very odd if this was 2.11.1 specific. It should have been caught by 2.11.0 tests on the PR?

I wonder if there is a small gap in the testing matrix somewhere

@potiuk
Copy link
Member

potiuk commented Feb 14, 2026

I think it's gap in test coverage - simply there is no e2e test in unit tests. It was discovered by celery executor getting response back from the task and I think those are mocked in the tests. Only the e2e tests that are run in 'target' airflow branch detect it.

One way t do it would be to run docker and k8s tests with old image (2.11) and new providers installed. Build new image by extending the existing 2.11 one and upgrade all providers from main

yes we could add it but that is a bit complex. We can add issue for it and add it some time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celery provider 3.16.0 breaks Airflow 2.11.1

3 participants