Fix navbar - hamburger menu rendering issues#475
Open
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:mainfrom
Open
Fix navbar - hamburger menu rendering issues#475Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:mainfrom
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429
Issue
The hamburger menu had rendering and interaction issues:
Solution
1. Fixed menu background and light mode readability
Before fix :
hamburger.menu.-.before.fix.vid.mp4
After fix :
hamburger.fix.vid.comp.mp4
2. Fixed menu interaction conflicts
Before fix :
dejacode.dropdown.menu.before.fix.vid.mp4
After fix :
dropdown.item.fix.vid.comp.mp4
Changes made
Files modified:
dejacode/static/css/dejacode_bootstrap.css- Added responsive navbar styles with theme suited backgrounds and colorsdejacode/static/js/navbar_menu_toggle.js- Created menu mutual exclusion logic using Bootstrap eventsdje/templates/includes/navbar_header.html- Included navbar toggle scriptLogic:
Testing
Tested locally
Menu interactions in all combinations tested in desktop view and mobile view
Both dark mode and light mode was tested
make valid- All checks passedmake test- 1781 tests passed