fix(examples): show end-of-list message in infinite scroll example#1123
Open
muraliavarma wants to merge 1 commit intoTanStack:mainfrom
Open
fix(examples): show end-of-list message in infinite scroll example#1123muraliavarma wants to merge 1 commit intoTanStack:mainfrom
muraliavarma wants to merge 1 commit intoTanStack:mainfrom
Conversation
The loader row was excluded from the virtualizer count when hasNextPage was false, so the end-of-list message never rendered. Always include the extra row and add a stop condition to demonstrate the behavior. Closes TanStack#1068
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
nextOffset < 5) so the example actually demonstrates the end-of-list behaviorThe issue was that
countexcluded the extra row whenhasNextPagewasfalse, meaning there was no virtual item slot to display the message.Closes #1068
✅ Checklist
pnpm run test:pr.🚀 Release Impact