test(preact-query/suspense): add test cases for 'static' staleTime with number and function by sukvvon · Pull Request #10134 · TanStack/query

sukvvon · 2026-02-14T03:24:12Z

🎯 Changes

Add test cases for 'static' staleTime in ensureSuspenseTimers to cover the clamp branch that preserves 'static' value as-is.

staleTime: 'static' (number type)
staleTime: () => 'static' (function type)
Use StaleTime type from @tanstack/query-core instead of inline type

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Improvements
- Enhanced type safety for staleTime configuration handling.
- Added test coverage for cache behavior with static and function-based staleTime values, ensuring proper caching behavior under various conditions.

…th number and function

changeset-bot · 2026-02-14T03:24:16Z

⚠️ No Changeset found

Latest commit: 689e2ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-14T03:24:36Z

📝 Walkthrough

Walkthrough

Updated staleTime type annotation in the suspense test helper from number | (() => number) to StaleTime | (() => StaleTime). Added two new test cases verifying that static staleTime values (both literal and function-based) prevent unnecessary re-fetches in suspense scenarios.

Changes

Cohort / File(s)	Summary
Suspense Test Type Updates and Static staleTime Tests `packages/preact-query/src/__tests__/suspense.test.tsx`	Updated test helper to accept typed `StaleTime` parameter instead of `number`, and added two new test cases validating that static staleTime values do not trigger additional fetches after initial data load under suspense.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test(react-query/suspense): add test cases for 'static' staleTime with number and function #10089: Implements identical test-level changes with the same StaleTime type migration and adds the same suspense tests for static staleTime values.

Suggested reviewers

TkDodo
manudeli

Poem

🐰 Hop along with type-checked time,
Static staleTime, perfectly aligned,
No re-fetches need apply,
Just suspense and tests standing by,
Clean and clear, this change feels right!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding test cases for 'static' staleTime with both number and function variants in the suspense test file.
Description check	✅ Passed	The description follows the template structure completely, includes all required sections with detailed explanations, and shows both checklist items completed appropriately.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-14T03:24:41Z

View your CI Pipeline Execution ↗ for commit 689e2ba

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 35s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-14 03:26:58 UTC

pkg-pr-new · 2026-02-14T03:25:50Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10134

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10134

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10134

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10134

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10134

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10134

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10134

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10134

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10134

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10134

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10134

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10134

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10134

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10134

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10134

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10134

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10134

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10134

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10134

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10134

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10134

commit: 689e2ba

test(preact-query/suspense): add test cases for 'static' staleTime wi…

689e2ba

…th number and function

github-actions bot added the package: preact-query label Feb 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(preact-query/suspense): add test cases for 'static' staleTime with number and function#10134

test(preact-query/suspense): add test cases for 'static' staleTime with number and function#10134
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/preact-query-suspense-static-staleTime

sukvvon commented Feb 14, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 14, 2026

Uh oh!

coderabbitai bot commented Feb 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Feb 14, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Feb 14, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Feb 14, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 14, 2026 •

edited

Loading

nx-cloud bot commented Feb 14, 2026 •

edited

Loading