Fix compile error with a DGUS LCD and FT_MOTION enabled#28322
Open
narno2202 wants to merge 4 commits intoMarlinFirmware:bugfix-2.1.xfrom
Open
Fix compile error with a DGUS LCD and FT_MOTION enabled#28322narno2202 wants to merge 4 commits intoMarlinFirmware:bugfix-2.1.xfrom
narno2202 wants to merge 4 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
oliof
reviewed
Feb 6, 2026
Marlin/src/inc/Conditionals-4-adv.h
Outdated
| #endif | ||
| // E jerk is derived from JD factors | ||
| #if ALL(HAS_JUNCTION_DEVIATION, LIN_ADVANCE) | ||
| #if (HAS_JUNCTION_DEVIATION && (LIN_ADVANCE || FTM_HAS_LIN_ADVANCE)) |
Contributor
There was a problem hiding this comment.
Why not
#if ANY(ALL(...), FTM_HAS_LIN_ADVANCE))
Also, the comment in line 410 would need updating.
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
16d71b9 to
097fc30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When there is a DGUS LCD (in my case MKS H43) and
FT_MOTIONenabled without linear advance, compilation fails withplanner.recalculate_max_e_jerk()not defined. Updating conditional forHAS_LINEAR_E_JERKin Conditionnals-4-adv.h solves the issue.Requirements
Benefits
Configurations
a DGUS LCD with FT_MOTION enabled without linear advance.
Related Issues