Fix Shape tool type dropdown not persisting selection and not excluding Line/Rectangle/Ellipse

[Ayush2k02]

Screen.Recording.2026-02-07.at.1.34.12.PM.2.mov

Fixes the issue from this discussion
https://discord.com/channels/731730685944922173/731738914812854303/1469590633361707204

[Ayush2k02]

These formatting changes are required else the CI formatting is failing , the versions I am using locally are

• rustfmt 1.8.0-stable
• rustc 1.92.0

[Ayush2k02]

whereas the CI uses rustc 1.93.0

[Ayush2k02]

[Keavon]

Thanks for fixing these two bugs. But I have a concern, which is that your implementation involved new logic, when in both cases, this already used to work and they each broke as a regression at some point in the past few months. I would expect an implementation should track down what broke and then fix what existing logic already performed the functionality for these two issues, rather than leaving behind the other logic in some unknown state and building new logic. Could you please spend some time to go back and check which commit broke both of these issues and post those PRs or commit hashes in a comment here, and then investigate what specific changes within each PR resulted in the regression, and then checking what minimal changes are required to fix the issues and seeing if the ones you did here are redundant?

[Ayush2k02]

Yeah, makes sense to fix that. Let me do that

[Keavon]

Any updates? Just checking how it's going, since this fix will be one of the more important ones to have merged.

[Ayush2k02]

yeah, will get this done today

…

On Mon, 16 Feb 2026 at 2:50 AM, Keavon Chambers ***@***.***> wrote: *Keavon* left a comment (GraphiteEditor/Graphite#3731) <#3731 (comment)> Any updates? Just checking how it's going, since this fix will be one of the more important ones to have merged. — Reply to this email directly, view it on GitHub <#3731 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXHAYMRHHQSXWTGQEZGWHL34MDPKVAVCNFSM6AAAAACUJ6I556VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBVGIYDKMZZGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>