fix(ci): Fix ECS deployment following attempted task definition separation#6719
Draft
matthewelwell wants to merge 3 commits intomainfrom
Draft
fix(ci): Fix ECS deployment following attempted task definition separation#6719matthewelwell wants to merge 3 commits intomainfrom
matthewelwell wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6719 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 1311 1311
Lines 48474 48474
=======================================
Hits 47617 47617
Misses 857 857 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the work started in this PR to use separate task definitions for the newly separated ECS services (admin API vs SDK).
Note: depends on: https://github.com/Flagsmith/pulumi/pull/160
How did you test this code?
TODO