Enable Chromium spellchecker for webview/editor#1617
Open
liu971227-sys wants to merge 1 commit intoBoostIO:masterfrom
Open
Enable Chromium spellchecker for webview/editor#1617liu971227-sys wants to merge 1 commit intoBoostIO:masterfrom
liu971227-sys wants to merge 1 commit intoBoostIO:masterfrom
Conversation
|
|
liu971227-sys
force-pushed
the
bounty/issuehunt-695-spellcheck
branch
from
0eaaa96 to
3762eb1
Compare
Author
|
This PR enables Chromium spellchecker at the Electron window + webview level (see description). Fixes #695. Note: CI may show |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable Chromium spellchecker for the Electron app and embedded BoostHub webview.
This change:
webPreferences.spellcheck = trueon the mainBrowserWindowso the built-in spellchecker is available.<webview>by addingspellcheck=yesto thewebpreferencesfeature string.Why
Issue #695 requests spellcheck support (as a preference toggle). Electron provides a built-in spellchecker; this PR wires it up at the window/webview level to make it available.
Fixes #695.
Notes
This does not force spellcheck on everywhere by itself; it ensures the capability is enabled. Actual editor behavior can still be controlled via
spellcheckattributes / app settings.